Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #3211 -> 9: Fix missing namespace for string #3239

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Backport #3211 -> 9: Fix missing namespace for string #3239

merged 1 commit into from
Jul 21, 2022

Conversation

scpeters
Copy link
Member

@Blast545
Copy link

CI is yellow for this PR on Homewbrew:

Build Status

@Crola1702
Copy link

@scpeters I think this is ready to be merged

@scpeters
Copy link
Member Author

I was slow to merge because I was investigating some test failures in homebrew, but it's a deeper problem unrelated to this PR (see #3242)

@scpeters scpeters merged commit f37fd3c into gazebo9 Jul 21, 2022
@scpeters scpeters deleted the scpeters/fix_string_9 branch July 21, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scpeters @Blast545 @Crola1702 @ahcorde @Tobias-Fischer