Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an API to retrieve keys. #446

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Conversation

arjo129
Copy link
Contributor

@arjo129 arjo129 commented Oct 4, 2022

This is useful for when we perform visualization.

Signed-off-by: Arjo Chakravarty arjo@openrobotics.org

This is useful for when we perform visualization.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@arjo129 arjo129 requested a review from mjcarroll as a code owner October 4, 2022 08:36
@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #446 (ff72afb) into mbari/gz-common5 (facac17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           mbari/gz-common5     #446   +/-   ##
=================================================
  Coverage             80.48%   80.49%           
=================================================
  Files                    88       88           
  Lines                 10111    10116    +5     
=================================================
+ Hits                   8138     8143    +5     
  Misses                 1973     1973           
Impacted Files Coverage Δ
io/include/gz/common/DataFrame.hh 78.12% <100.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

arjo129 added a commit to gazebosim/gz-sim that referenced this pull request Oct 5, 2022
Depends on:
* gazebosim/gz-math#508
* gazebosim/gz-common#446
Work in progress.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
arjo129 and others added 3 commits October 6, 2022 16:14
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@mjcarroll
Copy link
Contributor

@arjo129 I may have borked the merge here, can you take a look?

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
@arjo129
Copy link
Contributor Author

arjo129 commented Oct 6, 2022

Ahh all good. My bad I forgot to merge the upstream changes.

@mjcarroll mjcarroll merged commit 9bbf39c into mbari/gz-common5 Oct 6, 2022
@mjcarroll mjcarroll deleted the arjo/feat/list_keys branch October 6, 2022 15:53
hidmic pushed a commit that referenced this pull request Oct 17, 2022
This is useful for when we perform visualization.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
hidmic pushed a commit that referenced this pull request Oct 17, 2022
This is useful for when we perform visualization.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
arjo129 added a commit to gazebosim/gz-sim that referenced this pull request Nov 1, 2022
Depends on:
* gazebosim/gz-math#508
* gazebosim/gz-common#446
Work in progress.

Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants