You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plotting feature was implemented for ign-gui4 (dome) and then forward-ported to newer releases, however, it was never backported to ign-gui3(citadel) which is a LTS.
Implementation
I tried backporting it to ign-gui3. Here is the commit/branch: 1a4d323
And it seems to be working correctly:
Note: I had started following the instructions as it is explained in the contributions section about what is the correct way to backport a feature, which is using cherry-pick and fixing the conflicts. However, this feature was added in several commits and given it was added a year ago, some changes/bug-fixes affected those files afterward so that method wasn't that smooth.
If you give me the thumbs up and there is nothing that prevents us from backporting it I will go ahead and create PR based on the branch I shared.
Thanks for looking into it! The problematic bit is this change:
- class IGNITION_GUI_VISIBLE Application : public QGuiApplication+ class IGNITION_GUI_VISIBLE Application : public QApplication
This breaks ABI and can't be done in a stable distribution.
Thanks for the quick reply!
Oh you are right it can't be ported! Ok then, in our project we'll probably need to migrate to a newer release then.
(Fortress is candidate given that it is LTS, good timing :D).
Context
The plotting feature was implemented for
ign-gui4
(dome) and then forward-ported to newer releases, however, it was never backported toign-gui3
(citadel) which is a LTS.Implementation
I tried backporting it to ign-gui3. Here is the commit/branch: 1a4d323
And it seems to be working correctly:
Note: I had started following the instructions as it is explained in the
contributions
section about what is the correct way to backport a feature, which is using cherry-pick and fixing the conflicts. However, this feature was added in several commits and given it was added a year ago, some changes/bug-fixes affected those files afterward so that method wasn't that smooth.If you give me the thumbs up and there is nothing that prevents us from backporting it I will go ahead and create PR based on the branch I shared.
Related to #66
The text was updated successfully, but these errors were encountered: