Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ign-rendering 3.5 #264

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Require ign-rendering 3.5 #264

merged 1 commit into from
Aug 4, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Related to #263

Summary

This version is required since #223. We should be more diligent about bumping these on the pull requests that introduce the requirement.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine as a code owner August 3, 2021 16:44
@chapulina chapulina changed the base branch from ign-gui5 to ign-gui3 August 3, 2021 16:45
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 3, 2021
@chapulina chapulina added 🏰 citadel Ignition Citadel and removed 🏢 edifice Ignition Edifice labels Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #264 (a28bd5c) into ign-gui3 (81a0913) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           ign-gui3     #264   +/-   ##
=========================================
  Coverage     66.46%   66.46%           
=========================================
  Files            25       25           
  Lines          2949     2949           
=========================================
  Hits           1960     1960           
  Misses          989      989           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a0913...a28bd5c. Read the comment docs.

@chapulina chapulina merged commit abd4cf7 into ign-gui3 Aug 4, 2021
@chapulina chapulina deleted the chapulina/3/rendering3.5 branch August 4, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants