-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added winID to fix second windows in OGRE2.2 #292
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 65.31% 65.35% +0.04%
==========================================
Files 32 32
Lines 4621 4627 +6
==========================================
+ Hits 3018 3024 +6
Misses 1603 1603
Continue to review full report at Codecov.
|
hmm with this change and gazebosim/gz-rendering#436, I get an empty render window and then a crash on render. I'm on Ubuntu bionic with Qt 5.9.5 |
you probably used a world with the Gazebo Scene3D here it's the fix gazebosim/gz-sim#1063 |
Signed-off-by: ahcorde <ahcorde@gmail.com>
Issue fixed here for me with this branch. |
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍 We just need to wait for the ign-rendering
release before merging.
Actually there's no harm in merging this before an |
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Fix #291
Requires a PR in ign-rendering6
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge