Use fully-qualified message names to avoid deprecation warning #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov Report
@@ Coverage Diff @@
## gz-gui8 #575 +/- ##
===========================================
- Coverage 68.11% 68.07% -0.04%
===========================================
Files 38 38
Lines 5369 5369
===========================================
- Hits 3657 3655 -2
- Misses 1712 1714 +2
|
azeey
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gz-msgs now expects the factory to get fully qualified message names, and only provides the short name functionality with deprecation warnings.
This avoids the deprecation warnings, and should make message population more robust with 3rd-party messages.