Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGN_LAUNCH_CONFIG_PATH could accept path lists #92

Closed
peci1 opened this issue Feb 6, 2021 · 2 comments
Closed

IGN_LAUNCH_CONFIG_PATH could accept path lists #92

peci1 opened this issue Feb 6, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@peci1
Copy link
Contributor

peci1 commented Feb 6, 2021

Desired behavior

ign launch should try to prepend all colon-separated paths from IGN_LAUNCH_CONFIG_PATH when searching for a launch file to launch. Currently, this variable can contain only a single path.

Alternatives considered

All alternatives for combining multiple launch packages are bad.

Implementation suggestion

Shouldn't be difficult, but before submitting a PR, I wanted to know whether this feature would be desired/welcome.
@peci1 peci1 added the enhancement New feature or request label Feb 6, 2021
@chapulina
Copy link
Contributor

Sounds like a good idea to me 👍

@chapulina chapulina added the help wanted Extra attention is needed label Feb 6, 2021
This was referenced Feb 6, 2021
Closed
Merged
@peci1
Copy link
Contributor Author

peci1 commented Feb 1, 2022

Fixed by #93.

@peci1 peci1 closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peci1 @chapulina