Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standalone executables #121

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Add standalone executables #121

merged 4 commits into from
Jul 22, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 7, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

This keeps the ign.cc and ign.hh the same, and just provides a C++ entrypoint. This will help with the Windows port #120

Test it

Checklist

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Add standalone executables
91427dc 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll July 7, 2021 16:59
@ahcorde ahcorde self-assigned this Jul 7, 2021
@ahcorde ahcorde requested a review from nkoenig as a code owner July 7, 2021 16:59
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jul 7, 2021
@codecov
Copy link

codecov bot commented Jul 7, 2021 •
edited
Loading

Codecov Report

Merging #121 (ab5c7e8) into main (1ea966c) will increase coverage by 3.85%.
The diff coverage is 87.71%.

❗ Current head ab5c7e8 differs from pull request most recent head de24d55. Consider uploading reports for the commit de24d55 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   30.24%   34.09%   +3.85%     
==========================================
  Files           3        4       +1     
  Lines         734      786      +52     
==========================================
+ Hits          222      268      +46     
- Misses        512      518       +6
Impacted Files Coverage Δ
src/cmd/ign.cc 80.00% <80.00%> (ø)
src/cmd/launch_main.cc 88.46% <88.46%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea966c...de24d55. Read the comment docs.

@scpeters
Copy link
Member

scpeters commented Jul 7, 2021

I saw some code in the deleted .rb.in file about variable binding for erb with := syntax. I don't think we have a test for that and haven't tested but am guessing it isn't yet supported by this pull request

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 7, 2021

@scpeters it's supported here

https://github.com/ignitionrobotics/ign-launch/blob/91427dc559904bb6b6c48f24903ddfbf35c375b7/src/cmd/launch_main.cc#L84-L102

@scpeters
Copy link
Member

scpeters commented Jul 7, 2021

@scpeters it's supported here

https://github.com/ignitionrobotics/ign-launch/blob/91427dc559904bb6b6c48f24903ddfbf35c375b7/src/cmd/launch_main.cc#L84-L102

great work!

mjcarroll
mjcarroll reviewed Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. A few suggestions of transport to launch and maybe a place where we can increase coverage more.

src/cmd/cmdlaunch.rb.in Outdated Show resolved Hide resolved
src/cmd/CMakeLists.txt Outdated Show resolved Hide resolved
src/cmd/CMakeLists.txt Outdated Show resolved Hide resolved
src/cmd/CMakeLists.txt Outdated Show resolved Hide resolved
src/cmd/CMakeLists.txt Outdated Show resolved Hide resolved
src/cmd/launch_main.cc Show resolved Hide resolved
src/cmd/launch_main.cc Show resolved Hide resolved
ahcorde added 2 commits July 7, 2021 22:27
@ahcorde
Added feedback and more tests
6c86c46 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Add one more test
0119c8f 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll July 7, 2021 20:41
@ahcorde
Fixed test
de24d55 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 12, 2021

@osrf-jenkins retest this please

@ahcorde ahcorde mentioned this pull request Jul 13, 2021
Merged
8 tasks
@ahcorde ahcorde merged commit fc1efd2 into main Jul 22, 2021
@ahcorde ahcorde deleted the ahcorde/standalone_cli branch July 22, 2021 18:12
@chapulina chapulina mentioned this pull request Sep 2, 2021
Open
@chapulina chapulina mentioned this pull request Oct 18, 2021
Merged
7 tasks
@scpeters scpeters mentioned this pull request Apr 22, 2024
Open
Crola1702 pushed a commit that referenced this pull request Apr 25, 2024
@ahcorde @Crola1702
Add standalone executables (#121)
975464d 
* Add standalone executables

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Added feedback and more tests

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Add one more test

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Fixed test

Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees

@ahcorde ahcorde

Labels
🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @scpeters @mjcarroll