Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle emitters to link.proto and add topic to particle_emitter… #153

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Apr 5, 2021

🎉 New feature

Summary

Adds particle_emitter to Link and adds 'topic' to the 'particle_emitter'. Both of these reflect additions to SDF.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

….proto

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from caguero as a code owner April 5, 2021 17:14
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #153 (ad47c0f) into main (903e79b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files           7        7           
  Lines         828      828           
=======================================
  Hits          702      702           
  Misses        126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903e79b...ad47c0f. Read the comment docs.

@nkoenig nkoenig merged commit 739695d into main Apr 6, 2021
@nkoenig nkoenig deleted the particle_emitter_fortress branch April 6, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants