Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps in ionic : ci_matching_branch/bump_ionic_gz-msgs11 #401

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Bumps in ionic : ci_matching_branch/bump_ionic_gz-msgs11 #401

merged 4 commits into from
Oct 17, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Oct 16, 2023

azeey added 3 commits October 16, 2023 17:29
@azeey
Bumps in ionic : ci_matching_branch/bump_ionic_gz-msgs11
74059da 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Bumps in ionic : ci_matching_branch/bump_ionic_gz-msgs11
08d2580 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Bumps in ionic : ci_matching_branch/bump_ionic_gz-msgs11
0a5a92f 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey mentioned this pull request Oct 16, 2023
Closed
83 tasks
@azeey
Copy link
Contributor Author

azeey commented Oct 16, 2023

Needs gazebo-tooling/gzdev#72

@azeey
Fix transportlog13 to transportlog14
4a3412d 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey marked this pull request as ready for review October 16, 2023 23:27
@azeey azeey requested a review from caguero as a code owner October 16, 2023 23:27
@azeey azeey requested a review from iche033 October 16, 2023 23:27
@iche033
Copy link
Contributor

iche033 commented Oct 17, 2023 •
edited
Loading

I think ubuntu CI depends on gazebo-tooling/gzdev#72

update: ah ok already mentioned in previous comment

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #401 (90e293a) into main (ba82a93) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 90e293a differs from pull request most recent head 4a3412d. Consider uploading reports for the commit 4a3412d to get more accurate results

@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          27       27           
  Lines        1170     1170           
=======================================
  Hits         1138     1138           
  Misses         32       32
Files Coverage Δ
core/src/MessageFactory.cc 97.91% <100.00%> (ø)

@azeey azeey merged commit 03cacdb into main Oct 17, 2023
6 checks passed
@azeey azeey deleted the ci_matching_branch/bump_ionic_gz-msgs11 branch October 17, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @iche033