Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignition #119

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Remove ignition #119

merged 4 commits into from
Oct 13, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig requested review from mxgrey and ahcorde as code owners July 27, 2023 12:59
@nkoenig nkoenig marked this pull request as draft July 27, 2023 12:59
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #119 (0763468) into main (b7561e8) will increase coverage by 0.26%.
The diff coverage is n/a.

❗ Current head 0763468 differs from pull request most recent head 57a8bca. Consider uploading reports for the commit 57a8bca to get more accurate results

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   98.26%   98.52%   +0.26%     
==========================================
  Files          23       23              
  Lines         748      746       -2     
==========================================
  Hits          735      735              
+ Misses         13       11       -2     
Files Coverage Δ
loader/src/cmd/gz.cc 96.00% <ø> (+7.11%) ⬆️

... and 1 file with indirect coverage changes

nkoenig and others added 2 commits July 27, 2023 21:27
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@azeey azeey marked this pull request as ready for review October 13, 2023 17:42
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey merged commit c96ef14 into main Oct 13, 2023
4 of 6 checks passed
@azeey azeey deleted the nkoenig/remove-ign branch October 13, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants