ogre2: explicitly request OpenGL 3.3 core profile context. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iche033
reviewed
Mar 3, 2021
ogre2/src/Ogre2RenderEngine.cc
Outdated
| (PFNGLXCREATECONTEXTATTRIBSARBPROC) | ||
| glXGetProcAddress((const GLubyte*)"glXCreateContextAttribsARB"); | ||
|
|
||
| if (glXCreateContextAttribsARB) { |
ogre2/src/Ogre2RenderEngine.cc
Outdated
| glXCreateContextAttribsARB(x11Display, | ||
| this->dataPtr->dummyFBConfigs[0], nullptr, | ||
| 1, context_attribs); | ||
| } else { |
There was a problem hiding this comment.
else on new line and { also on it's own line, ie.e
}
else
{
...
}
ogre2/src/Ogre2RenderEngine.cc
Outdated
| glXGetProcAddress((const GLubyte*)"glXCreateContextAttribsARB"); | ||
|
|
||
| if (glXCreateContextAttribsARB) { | ||
| int context_attribs[] = { |
There was a problem hiding this comment.
use camelCase, i.e. contextAttribs[]
This change raises system requirements as it uses GLX 1.3 API and a GLX extension. Modern systems like Ubuntu bionic and focal satisfies these without issue. Signed-off-by: Hill Ma <hillma@google.com>
mahiuchun
force-pushed
the
context_attribs
branch
from
3d6f254 to
fdca12d
Compare
|
done |
iche033
approved these changes
Mar 5, 2021
ahcorde
pushed a commit
that referenced
this pull request
Mar 11, 2021
This change raises system requirements as it uses GLX 1.3 API and a GLX extension. Modern systems like Ubuntu bionic and focal satisfies these without issue. Signed-off-by: Hill Ma <hillma@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change raises system requirements as it uses GLX 1.3 API and a GLX extension. Modern systems like Ubuntu bionic and focal satisfies these without issue.
Tested on bionic without GPU (QEMU) and focal with GPU.
Bug Report
Fixes issue #128 and similar issues.
Summary
Newer GLX APIs are used to explicitly request core profile GL context that Ogre2 uses.
Reference:
https://www.khronos.org/opengl/wiki/Tutorial:_OpenGL_3.0_Context_Creation_(GLX)
Reproduce:
Run
ign gazebo shapes.sdfwith the default ogre2 renderer on systems with non-AMD (e.g. Intel) mesa GL drivers or in situations where the hardware GPU is not accessible (e.g. QEMU VM).The original code has a decent chance to fail due to it attempting to create OpenGL context in compatibility profile and the GL version of context created would be below the required 3.3.
Checklist
codecheckpassed (Seecontributing)
test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge