4 ➡️ 5 #264
4 ➡️ 5 #264
Conversation
* Examples: fix custom_scene_viewer for macOS 1. Add OpenGL context settings for macOS to the DemoWindow. 2. Move glutInit to main 3. Add command line option to set the ogre engine. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Examples: custom_scene_viewer ensure compliance with code standards 1. Use camel case for variables. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
* increase nosie std based on particle emitter size Signed-off-by: Ian Chen <ichen@osrfoundation.org> * tuning particle noise in shaders Signed-off-by: Ian Chen <ichen@osrfoundation.org> * apply change to depth camera Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix depth camera particle noise Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix tests Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix point cloud scattering Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: Rein Appeldoorn <reinzor@gmail.com>
Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
* Examples: fix gazebo_scene_viewer for macOS and ensure exits cleanly 1. Add OpenGL context settings for macOS to the CameraWindow. 2. Move glutInit to main in GazeboDemo and GazeboWorldDemo 3. Update CMakeLists.txt to exclude libstdc++fs for macOS and add find_package for bullet. 4. Expose command line option to set either ogre or ogre2 as an engine. 5. Ensure gazebo::transport is stopped and cleaned up prior to exit. 6. Use std::unique_ptr to manage current and new scene manager lifetimes. 7. Disconnect pub/sub from transport on SceneManager Fini. 8. Add checks in pub/sub callbacks to ensure scene manager pointers are valid. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Examples: gazebo_scene_viewer ensure compliance with code standards 1. Place return in braces following if 2. Use camel case for variables. Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com> * Examples: revert addition of Bullet to CMakeLists.txt in gazebo_scene_viewer Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* expose particle scatter ratio param Signed-off-by: Ian Chen <ichen@osrfoundation.org> * codecheck Signed-off-by: Ian Chen <ichen@osrfoundation.org> * test fix Signed-off-by: Ian Chen <ichen@osrfoundation.org> * address review comments Signed-off-by: Ian Chen <ichen@osrfoundation.org> * documentation tweaks Signed-off-by: Ashton Larkin <ashton@openrobotics.org> * testing Signed-off-by: Ian Chen <ichen@osrfoundation.org> * testing particle depth on actions Signed-off-by: Ian Chen <ichen@osrfoundation.org> * testing Signed-off-by: Ian Chen <ichen@osrfoundation.org> * revert changes, fix test Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
1c44912 to
4f21815
Compare
Codecov Report
@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 57.62% 57.77% +0.15%
==========================================
Files 151 153 +2
Lines 15328 15411 +83
==========================================
+ Hits 8833 8904 +71
- Misses 6495 6507 +12
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org> Signed-off-by: Ian Chen <ichen@osrfoundation.org>
There was a problem hiding this comment.
Windows CI failed, is that expected for Edifice (main branch)? I believe that Windows is usually green for Dome. Clicking on the "details" button of Windows CI leads to a 404, so I can't get any more information about the failure.
Also, it looks like this forward port is out of date with the branch comparison. @chapulina, can you update this forward port to get the latest commits on ign-rendering4? I currently see 14 commits in the branch comparison (the last one being d98ea2a).
chapulina
force-pushed
the
chapulina/4_to_5
branch
from
4f21815 to
e66fbad
Compare
|
@adlarkin , I addressed your comments and pushed, let's see if Windows CI comes back now. |
|
Windows already failed, it looks like there's an issue with getting dependencies for the build (https://build.osrfoundation.org/job/ign_rendering-pr-win/1442/consoleFull#1273209513aa60f765-a60a-427d-900c-dc128ab22287): |
|
Ahhhh
Here we go: gazebo-tooling/gazebodistro#30 |
|
Nice catch, I missed that when scanning output in Windows CI. gazebo-tooling/gazebodistro#30 has been approved, so I think all we need to do now is merge that and then run Windows CI one last time 🤞 |
|
All 🟢 |
➡️ Forward port
Port
ign-rendering4tomainBranch comparison: main...ign-rendering4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸