Expose particle scatter ratio parameter #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
8 tasks
adlarkin
reviewed
Mar 11, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
adlarkin
reviewed
Mar 12, 2021
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
adlarkin
approved these changes
Mar 12, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-rendering4 #269 +/- ##
==================================================
+ Coverage 52.59% 53.50% +0.91%
==================================================
Files 143 145 +2
Lines 13329 13754 +425
==================================================
+ Hits 7010 7359 +349
- Misses 6319 6395 +76
Continue to review full report at Codecov.
|
|
CI is green, merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🎉 New feature
Summary
used by gazebosim/gz-sim#674
This lets users configure the particle scatter ratio parameter that was previously hardcoded in a couple different sensor src files.
The
particleScatterRatioparam determines the amount of scattering effect applied to sensors (depth camera and lidars). The higher the value, the more "scattering" (noise) is added to the depth readings. This value was fixed and now it's configuration though theParticleEmitter'sUserAnyobjectTest it
see gazebosim/gz-sim#674
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge