Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more doc mentioning the reason for a Capsule class #859

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 6, 2023

🦟 Bug fix

Fixes #856

Summary

Expanded the doxygen comments in the Capsule to explain the reason behind the APIs: #200 (review)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit b32cbd3 into gz-rendering7 Jun 6, 2023
@iche033 iche033 deleted the capsule_desc branch June 6, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Why does Scene::CreateCapsule not return GeometryPtr like the other shape methods?
2 participants