5 ➡️ 6 (main)

[chapulina]

➡️ Forward port

Port ign-gazebo5 to main

Branch comparison: main...ign-gazebo5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

[jennuine]

On Ubuntu Focal, ign gazebo -v 4 lights.sdf isn't working as expected. When I use the sliders to change the colors of the lights in the component inspector nothing happens. Also, when I transform an object then try to interact with the lights again I can't. The same is happening in main as well (after applying this fix #1018). This could be related to gazebosim/gz-rendering#402

[jennuine]

gazebosim/gz-rendering#402 turned out not to be the issue. I'm still having the same issues with lights but it's also happening in main so I've ticketed an issue: #1022

I believe I was not able to interact with the lights after transforming an object because the tool was still in transform mode. When I'm back in select mode I'm able to select the light entities again.

There are failing tests from SdfGenerator_TEST.cc should they be addressed in this PR?

[chapulina]

I believe I was not able to interact with the lights after transforming an object because the tool was still in transform mode. When I'm back in select mode I'm able to select the light entities again.

Great detective work!

There are failing tests from SdfGenerator_TEST.cc should they be addressed in this PR?

I've noticed these new test failures on main too, but haven't looked into it: https://build.osrfoundation.org/job/ignition_gazebo-ci-main-bionic-amd64/75/

[azeey]

There are failing tests from SdfGenerator_TEST.cc should they be addressed in this PR?

I've noticed these new test failures on main too, but haven't looked into it: https://build.osrfoundation.org/job/ignition_gazebo-ci-main-bionic-amd64/75/

Should be fixed by #1023

[codecov]

Codecov Report

Merging #1020 (f0e235b) into main (e3ee0af) will decrease coverage by 1.38%.
The diff coverage is 49.80%.

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   64.66%   63.28%   -1.39%     
==========================================
  Files         242      238       -4     
  Lines       19014    19423     +409     
==========================================
- Hits        12296    12292       -4     
- Misses       6718     7131     +413     

Impacted Files	Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh	100.00% <ø> (ø)
include/ignition/gazebo/Link.hh	100.00% <ø> (ø)
include/ignition/gazebo/Server.hh	100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh	100.00% <ø> (ø)
...nclude/ignition/gazebo/components/ContactSensor.hh	100.00% <ø> (ø)
...nclude/ignition/gazebo/components/LogicalCamera.hh	100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh	100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh	0.00% <0.00%> (ø)
include/ignition/gazebo/gui/GuiSystem.hh	0.00% <0.00%> (ø)
include/ignition/gazebo/rendering/RenderUtil.hh	100.00% <ø> (ø)
... and 92 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 899034b...f0e235b. Read the comment docs.