Add bounding boxes back into the label system plugin #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Modified the RenderUtil & SdfEntityCreator to recognize the new components Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
…into main Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
…into main Signed-off-by: AmrElsersy <amrelsersay@gmail.com>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
chapulina
added
the
needs upstream release
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added
enhancement
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1040 +/- ##
===============================================
- Coverage 64.04% 64.00% -0.04%
===============================================
Files 316 317 +1
Lines 25478 25509 +31
===============================================
+ Hits 16317 16328 +11
- Misses 9161 9181 +20
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This builds on top of #853 to add the bounding box functionality back into the label system. This was originally a part of #853, but since we are only supporting the segmentation sensor in the initial Fortress release, the bounding box functionality has been placed here and will be merged in once the other bounding box PRs in
ign-sensorsandign-renderinghave been merged.Test it
TODO tests need to be added for this system plugin
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge