Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump main to 7.0.0~pre1 #1094

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Bump main to 7.0.0~pre1 #1094

merged 2 commits into from
Oct 15, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from mabelzhang as a code owner October 7, 2021 22:03
@chapulina chapulina changed the title Bump main to 6.0.0~pre1 Bump main to 7.0.0~pre1 Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #1094 (401b091) into main (30df078) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 401b091 differs from pull request most recent head 1fb53d8. Consider uploading reports for the commit 1fb53d8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1094      +/-   ##
==========================================
- Coverage   64.11%   64.07%   -0.04%     
==========================================
  Files         255      255              
  Lines       19994    19994              
==========================================
- Hits        12819    12812       -7     
- Misses       7175     7182       +7     
Impacted Files Coverage Δ
src/gui/plugins/plot_3d/Plot3D.cc 43.47% <0.00%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30df078...1fb53d8. Read the comment docs.

Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focal CI is failing.

I think the fix is to change this line in examples/standalone/gtest_setup/CMakeLists.txt to 7:

set(IGN_GAZEBO_VER 6)

or better, use the same pattern as the other examples:

find_package(ignition-gazebo7 REQUIRED)
set(IGN_GAZEBO_VER ${ignition-gazebo7_VERSION_MAJOR})

The errors are:

  [  FAILED  ] Plugins/ExamplesBuild.Build/1, where GetParam() = "standalone" (90440 ms)
  [----------] 2 tests from Plugins/ExamplesBuild (189044 ms total)
  
  [----------] Global test environment tear-down
  [==========] 2 tests from 1 test suite ran. (189044 ms total)
  [  PASSED  ] 1 test.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] Plugins/ExamplesBuild.Build/1, where GetParam() = "standalone"
  CMake Error at CMakeLists.txt:7 (find_package):
    By not providing "Findignition-gazebo6.cmake" in CMAKE_MODULE_PATH this
    project has asked CMake to find a package configuration file provided by
    "ignition-gazebo6", but CMake did not find one.
  
    Could not find a package configuration file provided by "ignition-gazebo6"
    with any of the following names:
  
      ignition-gazebo6Config.cmake
      ignition-gazebo6-config.cmake
  
    Add the installation prefix of "ignition-gazebo6" to CMAKE_PREFIX_PATH or
    set "ignition-gazebo6_DIR" to a directory containing one of the above
    files.  If "ignition-gazebo6" provides a separate development package or
    SDK, be sure it has been installed.

A second error I'm not sure what it's talking about:

  [Dbg] [examples_build.cc:164] Source: /github/workspace/examples/standalone/gtest_setup
  [Dbg] [examples_build.cc:170] Build directory: /tmp/l2yWzm
  /github/workspace/test/integration/examples_build.cc:177: Failure
  Expected equality of these values:
    system(cmd)
      Which is: 256
    0
  gtest_setup

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

INTEGRATION_examples_build is timing out on Focal actions. I think it's not related to this PR, we probably have too many examples and have to bump the timeout. I think that can come in a separate PR, and will probably need to target earlier versions too.

@chapulina chapulina merged commit 5bde564 into main Oct 15, 2021
@chapulina chapulina deleted the chapulina/bump_7 branch October 15, 2021 19:11
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants