Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2458 - Checking linkEnity is empty #2509

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix #2458 - Checking linkEnity is empty #2509

merged 2 commits into from
Aug 6, 2024

Conversation

akky20
Copy link
Contributor

@akky20 akky20 commented Aug 4, 2024 •
edited
Loading

🦟 Bug fix

Fixes #

Summary

Added a if condition for checking whether the linkEntity is empty or not , if this condition is removed then the issue comes again

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@akky20
Fix gazebosim#2458 - checking linkEnity is empty
f8d8b7c 
Signed-off-by: Abhiroop Bhavsar <b22me002@iitj.ac.in>
@akky20 akky20 requested a review from mjcarroll as a code owner August 4, 2024 09:33
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 4, 2024
arjo129
arjo129 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@arjo129 arjo129 linked an issue Aug 5, 2024 that may be closed by this pull request
Crash caused by service "/world/default/enable_collision" #2458
Closed
arjo129
arjo129 requested changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This fixes the bug. However there is a minor style issue that needs fixing.

src/systems/user_commands/UserCommands.cc Outdated Show resolved Hide resolved
@akky20 @arjo129
Update src/systems/user_commands/UserCommands.cc
2b283e2 
Co-authored-by: Arjo Chakravarty <arjo129@gmail.com>
Signed-off-by: Abhiroop Bhavsar <126786356+akky20@users.noreply.github.com>
akky20
akky20 commented Aug 5, 2024
View reviewed changes
Copy link
Contributor Author

@akky20 akky20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have submitted the changes please have a look

@arjo129 arjo129 merged commit 5f03199 into gazebosim:gz-sim8 Aug 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@arjo129 arjo129 arjo129 approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash caused by service "/world/default/enable_collision"
3 participants
@akky20 @arjo129 @iche033