Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/parallel download #2672

Draft
wants to merge 3 commits into
base: gz-sim8
Choose a base branch
from
Draft

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Nov 11, 2024

Not looking for a review yet.

🎉 New feature

Closes #1260

Summary

This replaces #1669.

The PR changes the Server load to:

  1. Disable Fuel downloads.
  2. Parse the SDF file/string.
  3. Remove all models, actors, and lights from each world.
  4. Create the worlds (runners).
  5. Enable Fuel downloads and force simulation to be paused. User cannot unpause.
  6. Start a thread that parses the SDF file again. This time models are downloaded.
  7. Add the models back into the worlds.
  8. Allow the pause state in simulation to change.

The above will be followed even if nothing needs to be downloaded.

Test it

All of the tests should pass, and you should be able to clear your fuel cache and load world like tunnel.sdf

Checklist

  • [] Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig marked this pull request as draft November 11, 2024 14:19
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 11, 2024
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Copy link
Contributor Author

nkoenig commented Nov 19, 2024

@osrf-jenkins run tests please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

1 participant