Add parameter for adjust current sign in battery plugin #2696
+36
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
Tacha-S
force-pushed
the
bugfix/current-sign
branch
from
92c8eac to
fc1a2d5
Compare
ahcorde
requested changes
Dec 10, 2024
| @@ -178,6 +178,9 @@ class gz::sim::systems::LinearBatteryPluginPrivate | |||
|
|
|||
| /// \brief Initial power load set trough config | |||
| public: double initialPowerLoad = 0.0; | |||
|
|
|||
| /// \brief Adjusts the sign of the current to align with ROS conventions. | |||
| public: bool adjustCurrentSignForROS{false}; | |||
There was a problem hiding this comment.
Do you mind to use a different value for the parameter ? We try not to include any ROS related stuff here.
Maybe something like invertSignValues ? But I open to suggestions
There was a problem hiding this comment.
I was also considering using a variable like that, so I agree with the idea.
However, it's not clear what the sign is being inverted for, so how about naming it invertCurrentSign?
There was a problem hiding this comment.
go ahead with invertCurrentSign 👌
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
ahcorde
approved these changes
Dec 11, 2024
ahcorde
changed the title
azeey
reviewed
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2685
Summary
A parameter has been added to adjust the sign of the battery current value to comply with ROS conventions.
By default, it is set to
false, so the existing behavior remains unchanged.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.