👩🌾 Refactor UNIT_Server_TEST: move tests to integration #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #594 +/- ##
============================================
Coverage 77.36% 77.36%
============================================
Files 215 215
Lines 12029 12029
============================================
Hits 9306 9306
Misses 2723 2723 Continue to review full report at Codecov.
|
Move several server interactions and fuel cached to their own tests in integration. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
…into ign-gazebo4_refactor_server_test Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
force-pushed
the
ign-gazebo4_refactor_server_test
branch
from
c53a2a9 to
d5a513c
Compare
chapulina
approved these changes
Feb 2, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580
Move several server interactions and fuel cached to their own tests under integration, seems to me that they fit better there than in a "unit" test. I split the server Fixture not to copy/paste code all around.