Removed duplicated code with rendering::sceneFromFirstRenderEngine #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
mjcarroll
added
the
needs upstream release
7 tasks
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #819 +/- ##
===============================================
+ Coverage 77.76% 77.88% +0.12%
===============================================
Files 216 216
Lines 12150 12131 -19
===============================================
Hits 9448 9448
+ Misses 2702 2683 -19
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
mjcarroll
approved these changes
May 27, 2021
|
@osrf-jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
Enhancement
Summary
Related to this PR in ignition-renderin gazebosim/gz-rendering#320 (comment). It uses the helper function rendering::sceneFromFirstRenderEngine to get the first scene that can be found in any rendering engine.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge