-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RenderUtil::Update with helper functions #858
Conversation
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a few comments/questions for PR reviewers.
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #858 +/- ##
===============================================
- Coverage 65.69% 65.68% -0.01%
===============================================
Files 240 240
Lines 17797 17811 +14
===============================================
+ Hits 11691 11700 +9
- Misses 6106 6111 +5
Continue to review full report at Codecov.
|
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
Summary
#853 (comment) makes changes that result in
RenderUtil::Update
being longer than 500 lines of code (yikes!). It looks like several new features were introduced inign-gazebo4
(thermal camera, lights, etc.) that have added a lot of code toRenderUtil::Update
. So, I have introduced some helper functions that can be called inRenderUtil::Update
to reduce this method's size.Once this is merged, we can forward-port this so that all other branches/PRs don't have this issue appear anymore. It's also worth noting that I only introduced helper functions for code that was introduced in
ign-gazebo4
so that we (hopefully) don't get any nasty merge conflicts when we mergeign-gazebo3
forward.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge