Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection buffer crash on resize #969

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 12, 2021

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

related ign-rendering PR: gazebosim/gz-rendering#378
related issue: gazebosim/gz-rendering#362

Summary

If a window resize and mouse click happens in the same frame, the gui will crash with a backtrace pointing to the selection buffer in ign-rendering. This is more of a workaround - adding a render call ensures that the ogre resources are ready before they are used by the selection buffer (for mouse picking).

Note: we need to merge this PR before the one in ign-rendering: gazebosim/gz-rendering#378

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #969 (98146d5) into ign-gazebo4 (2105ae3) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4     #969      +/-   ##
===============================================
- Coverage        66.08%   65.48%   -0.60%     
===============================================
  Files              242      243       +1     
  Lines            18078    20798    +2720     
===============================================
+ Hits             11946    13619    +1673     
- Misses            6132     7179    +1047     
Impacted Files Coverage Δ
src/gui/plugins/scene3d/Scene3D.cc 10.63% <0.00%> (+0.68%) ⬆️
src/gui/plugins/scene3d/Scene3D.hh 60.00% <0.00%> (-6.67%) ⬇️
src/ServerConfig.cc 89.08% <0.00%> (-0.61%) ⬇️
src/systems/imu/Imu.hh 100.00% <0.00%> (ø)
src/systems/contact/Contact.hh 100.00% <0.00%> (ø)
src/systems/physics/Physics.hh 100.00% <0.00%> (ø)
src/systems/altimeter/Altimeter.hh 100.00% <0.00%> (ø)
src/systems/breadcrumbs/Breadcrumbs.hh 100.00% <0.00%> (ø)
src/systems/air_pressure/AirPressure.hh 100.00% <0.00%> (ø)
src/systems/wind_effects/WindEffects.hh 100.00% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2105ae3...98146d5. Read the comment docs.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@chapulina chapulina merged commit 1e6a9d1 into ign-gazebo4 Sep 3, 2021
@chapulina chapulina deleted the fix_selection_buffer_crash branch September 3, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants