Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in fortress : ign-transport11 #238

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner April 13, 2021 23:40
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Apr 14, 2021
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #238 (86b1350) into main (3f6691d) will not change coverage.
The diff coverage is n/a.

❗ Current head 86b1350 differs from pull request most recent head 36308c1. Consider uploading reports for the commit 36308c1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          49       49           
  Lines        4678     4678           
=======================================
  Hits         4167     4167           
  Misses        511      511           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6691d...36308c1. Read the comment docs.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Apr 14, 2021
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it matters, but it looks like the bitbucket-pipelines.yml is out of date: https://github.com/ignitionrobotics/ign-transport/blob/bump_fortress_ign-transport11/bitbucket-pipelines.yml#L30

@chapulina
Copy link
Contributor Author

Not sure if it matters, but it looks like the bitbucket-pipelines.yml is out of date:

I haven't been worrying about that too much since only the first line is still used.

@chapulina chapulina merged commit 1135166 into main Apr 15, 2021
@chapulina chapulina deleted the bump_fortress_ign-transport11 branch April 15, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants