Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘©β€πŸŒΎ Remove deprecated test #239

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

The REGRESSION_deprecated test was originally added to test deprecated functions in 2e2baca.

On ign-transport5, the deprecated functions were tocked out, but the test remained, empty.

I believe it should be ok to remove this test since it isn't doing anything that other tests aren't already.

Checklist

  • Signed all commits for DCO
  • Added Removed tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

πŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”Έ

https://github.com/osrf/buildfarmer/issues/181

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from caguero as a code owner April 21, 2021 21:20
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #239 (b731f10) into ign-transport8 (b566563) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-transport8     #239   +/-   ##
===============================================
  Coverage           83.76%   83.76%           
===============================================
  Files                  51       51           
  Lines                5033     5033           
===============================================
  Hits                 4216     4216           
  Misses                817      817           

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update b566563...b731f10. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not familiar with ign-transport. Maybe a second pair of πŸ‘€?

Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we can remove it.

@chapulina chapulina merged commit d8a31da into ign-transport8 Apr 30, 2021
@chapulina chapulina deleted the chapulina/8/deprecated branch April 30, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants