Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 1 1 prep #256

Merged
merged 1 commit into from
Aug 12, 2021
Merged

9 1 1 prep #256

merged 1 commit into from
Aug 12, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 12, 2021

🎈 Release

Preparation for 9.1.1 release.

Comparison to 9.1.1: ignition-transport9_9.1.0...ign-transport9

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • [] Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from caguero August 12, 2021 19:26
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 12, 2021
@mjcarroll
Copy link
Contributor

I believe that this is targeting the wrong branch.

@nkoenig nkoenig changed the base branch from ign-transport10 to ign-transport9 August 12, 2021 19:33
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #256 (94ea79c) into ign-transport9 (11c22ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-transport9     #256   +/-   ##
===============================================
  Coverage           88.91%   88.91%           
===============================================
  Files                  49       49           
  Lines                4674     4674           
===============================================
  Hits                 4156     4156           
  Misses                518      518           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c22ea...94ea79c. Read the comment docs.

@nkoenig
Copy link
Contributor Author

nkoenig commented Aug 12, 2021

I believe that this is targeting the wrong branch.

Thanks, fixed.

@mjcarroll
Copy link
Contributor

@osrf-jenkins retest this please

@nkoenig nkoenig merged commit 2aafdc1 into ign-transport9 Aug 12, 2021
@nkoenig nkoenig deleted the 9-1-1-prep branch August 12, 2021 20:52
@chapulina chapulina added 🔮 dome Ignition Dome and removed 🏢 edifice Ignition Edifice labels Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants