Documentation for the design of the DOM API #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
scpeters
reviewed
Feb 11, 2022
developers/dom_api.md
Outdated
| the API does now allow modifying existing child objects or adding or removing | ||
| child objects. | ||
|
|
||
| * The frame graph is only built during `sdf::Root::Load`. Subsequent updates to |
Member
There was a problem hiding this comment.
which version of SDFormat does this apply to? I know we changed things between 1.7 and 1.8
Collaborator
Author
There was a problem hiding this comment.
Yes, this statement is true only for >= libsdformat 11.0.0. I'll update it to reflect what how it works in 9.x-10.x.
Where the graphs are built depends on the version of libsdformat. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves gazebosim/sdformat#292
Summary
Preview: http://sdformat.org/tutorials?tut=dom_api&cat=developers&branch=dom_api&repo=https%3A%2F%2Fgithub.com%2Fazeey%2Fsdf_tutorials
Checklist
[ ] Signed all commits for DCO[ ] Added tests[ ] Updated migration guide (as needed)[ ]codecheckpassed (See contributing)[ ] All tests passed (See test coverage)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.