Fixed file path in errors when parsing sdf or urdf from string #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've posted some feedback in #536; can you look at it and let me know what you think?
Codecov Report
@@ Coverage Diff @@
## sdf11 #537 +/- ##
=======================================
Coverage 87.46% 87.47%
=======================================
Files 72 72
Lines 10349 10352 +3
=======================================
+ Hits 9052 9055 +3
Misses 1297 1297
Continue to review full report at Codecov.
|
… checks FilePath during construction, added tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ti-line and single line string Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
force-pushed
the
aaron/fix-string-parsing-error-bug
branch
from
d8885e7 to
09b866b
Compare
EricCousineau-TRI
approved these changes
Apr 22, 2021
…har[] Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
|
@osrf-jenkins run test |
azeey
reviewed
Apr 23, 2021
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
azeey
approved these changes
Apr 28, 2021
|
oops, @aaronchongth please use squash merge next time. |
|
@azeey I apologize, I thought I selected squash merge for the auto-merging, I'll do it manually in the future just in case |
7 tasks
This was referenced Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Chong aaronchongth@gmail.com
🦟 Bug fix
Fixes #536
Summary
Checklist
sh tools/code_check.sh)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge