-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: Use encapsulated string constants for non-file sources #551
Conversation
I think this will change behavior in a stable release. The string "data-string" is used in a stable release of ign-gazebo. Can we target this to |
True. How about keeping the string as |
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
555a467
to
bfa2861
Compare
Done! Retargeted Meta: I'm a wee bit confused on release process and expected stability for version branches and all that. Y'all got a page that explains that part? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for quick fixes!
Meta: I'm a wee bit confused on release process and expected stability for version branches and all that. Y'all got a page that explains that part?
I would be curious to learn more about this too
Per VC, ABI checker failure may be due to statefulness; @azeey will try to re-run; simplest mitigation may be to ignore CI results and merge pending approval. Most likely, job got queued upon initial PR, but didn't go away when branch was retargeted. |
🦟 Bug fix
Fixes #536, follow-up to #537
Downstream: gazebosim/gz-sim#794
Summary
Takes prior revision of #537.
Checklist
sh tools/code_check.sh
)test coverage)
another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge