Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Expanding macro args inside string literals hangs if the literal is >256 characters #762

Closed
Rangi42 opened this issue Feb 24, 2021 · 0 comments · Fixed by #747
Closed

[Bug] Expanding macro args inside string literals hangs if the literal is >256 characters #762

Rangi42 opened this issue Feb 24, 2021 · 0 comments · Fixed by #747
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM
Milestone
v0.5.0

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Feb 24, 2021 

mac: MACRO
	println "\1" ; x1
	println "\1\1\1\1\1\1" ; x6
ENDM

	mac Hello!
	mac This sentence spans forty-three characters.

This outputs:

Hello!
Hello!Hello!Hello!Hello!Hello!Hello!
This sentence spans forty-three characters.

and then freezes. 43×6 would be 258 characters.
@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM labels Feb 24, 2021
@Rangi42 Rangi42 added this to the v0.5.0 milestone Feb 24, 2021
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Feb 24, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
390fa72 
Fixes gbdev#762
@Rangi42 Rangi42 mentioned this issue Feb 24, 2021
Merged
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Feb 24, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
26db24f 
Fixes gbdev#762
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Feb 24, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
6b9d316 
Fixes gbdev#762
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Feb 25, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
9d451a0 
Fixes gbdev#762
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Feb 28, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
eb89bba 
Fixes gbdev#762
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Feb 28, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
1e1373f 
Fixes gbdev#762
Rangi42 added a commit that referenced this issue Feb 28, 2021
@Rangi42
append_yylval_tzString should always evaluate its argument
63d15ac 
Fixes #762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Fix some macro argument issues Rangi42/rgbds
1 participant
@Rangi42