Vimode: handle fold and margin click event #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
techee
requested changes
May 22, 2024
There was a problem hiding this comment.
Looks good. There's just the minor formatting issue plus I noticed that right now there's a merge conflict, probably because of the other vimode PR I merged - would you have a look at that?
You can just squash the result into one commit, I don't expect any more problems.
vimode/src/vi.c
Outdated
| @@ -306,6 +306,14 @@ gboolean vi_notify_sci(SCNotification *nt) | |||
| } | |||
| } | |||
|
|
|||
| if (nt->nmhdr.code == SCN_MARGINCLICK) { | |||
There was a problem hiding this comment.
Maybe just { on a separate line.
scresto09
force-pushed
the
vimode-handle-fold-marginclick
branch
from
2c473da
to
ba05577
Compare
|
@scresto09 You seem to have accidentally pushed the commit together with the already merged pull request - could you fix that? |
scresto09
force-pushed
the
vimode-handle-fold-marginclick
branch
from
ba05577
to
d861058
Compare
scresto09
force-pushed
the
vimode-handle-fold-marginclick
branch
from
d861058
to
fade2b7
Compare
|
Is it better now ? |
|
Yep, looks good, merged. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically set the cursor position on the visible line on SCN_MARGINCLICK event