Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(workspace): inherit dependencies from workspace for version management #2427

Merged
merged 33 commits into from
Apr 3, 2023
Merged

perf(workspace): inherit dependencies from workspace for version management #2427

merged 33 commits into from
Apr 3, 2023

Conversation

clearloop
Copy link
Contributor

@clearloop clearloop commented Mar 20, 2023 •
edited
Loading

Resolves #2359
Resolves #2444

Deduplicate dependency directives through [workspace.dependencies], save lives for updating substrate dependencies

  • core libraries
  • g-prefix libraries
  • node
  • pallets
  • runtime
  • utils
  • examples?

@gear-tech/dev

@clearloop
Copy link
Contributor Author

clearloop commented Mar 21, 2023 •
edited
Loading

https://github.com/gear-tech/gear/actions/runs/4480529884/jobs/7875971621?pr=2427#step:24:15

The logic inside proc-macro Encode can not find ::parity_scale_codec if not specifying package = "parity-scale-codec", these warnings could be error printed by rust-lang/cargo#11630 since

rustc 1.70.0-nightly (da7c50c08 2023-03-19) prints these warnings, but
rustc 1.68.0 (2c8cc3432 2023-03-06) not

UPDATED

https://github.com/paritytech/parity-scale-codec/blob/1ecacab0d839778fa12ba4162ff541b2a7fc0f5b/derive/src/utils.rs#L130

this function caused the problem, it has not supported the workspace syntax yet

@clearloop
chore(workspace): remove unused specified package name in manifests
75d3178
@clearloop
Merge branch 'master' into cl/issue-2359
6511f79
@clearloop
Merge branch 'master' into cl/issue-2359
e49cfc2
@clearloop
feat(runtime): inherit workspace dependencies
dfcf1d6
@clearloop
feat(pallets): inherit workspace dependencies
2014e67
@clearloop
Merge branch 'master' into cl/issue-2359
0698a4a
@clearloop
feat(examples): inherit gear dependencies from workspace
63a5e71
@clearloop
Merge branch 'master' into cl/issue-2359
6dc19a1
@clearloop
Merge branch 'master' into cl/issue-2359
e85a451
@clearloop
chore(pallets): add std features for dev-dependencies
2504fdb
@clearloop
chore(dep): squash parity-scale-codec to clean the warning messages f…
9460af7 
…rom the latest cargo
@clearloop
fix(pallets): imports of codec in tests
b9f0bc7
@clearloop
chore(gsdk): std feature
0a6bbe5
@clearloop
chore(examples): no default features for g-prefix deps
b12ec05
@breathx breathx added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Mar 26, 2023
@clearloop clearloop changed the title perf(cargo): inherit dependencies from workspace for version management perf(workspace): inherit dependencies from workspace for version management Mar 28, 2023
clearloop
clearloop commented Mar 28, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
common/Cargo.toml Outdated Show resolved Hide resolved
pallets/gear/Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
core-errors/Cargo.toml Show resolved Hide resolved
@clearloop clearloop marked this pull request as ready for review March 28, 2023 13:09
@clearloop clearloop added A0-pleasereview PR is ready to be reviewed by the team and removed A1-inprogress Issue is in progress or PR draft is not ready to be reviewed labels Mar 28, 2023
shamilsan
shamilsan reviewed Mar 29, 2023
View reviewed changes
common/Cargo.toml Outdated Show resolved Hide resolved
@clearloop clearloop added E1-forcewindows E2-forcemacos Force CI to run macOS build in PR labels Apr 3, 2023
@clearloop clearloop merged commit 33b723a into master Apr 3, 2023
@clearloop clearloop deleted the cl/issue-2359 branch April 3, 2023 14:15
@clearloop clearloop mentioned this pull request Apr 3, 2023
Closed
This was referenced May 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamilsan shamilsan shamilsan approved these changes

@ukint-vs ukint-vs Awaiting requested review from ukint-vs

@breathx breathx Awaiting requested review from breathx

@gshep gshep Awaiting requested review from gshep

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team E2-forcemacos Force CI to run macOS build in PR
Projects
None yet
Milestone
No milestone
3 participants
@clearloop @shamilsan @breathx