decode unicode as ascii

gebn · Jan 28, 2024 · bc91ac8 · bc91ac8
1 parent dc9d435
commit bc91ac8
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/ipmi/id_string.go b/pkg/ipmi/id_string.go
@@ -68,7 +68,9 @@ var (
  // turning them into Go strings. These functions are not implemented inline
  // to ease readability and testability
  stringEncodingDecoders = map[StringEncoding]StringDecoder{
- // no decoder for StringEncodingUnicode, as ambiguous
+ // despite the ambiguity of StringEncodingUnicode, we follow OpenIPMI
+ // and decode it as 8-bit ASCII
+ StringEncodingUnicode: StringDecoderFunc(decode8BitAsciiLatin1),
  StringEncodingBCDPlus: StringDecoderFunc(decodeBCDPlus),
  StringEncodingPacked6BitAscii: StringDecoderFunc(decodePacked6BitAscii),
  StringEncoding8BitAsciiLatin1: StringDecoderFunc(decode8BitAsciiLatin1),