Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-0 LUN for GetSensorReadingCmd #58

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

lukeyeager
Copy link
Contributor

Close #56

@lukeyeager
Copy link
Contributor Author

Assuming you don't have a BMC to test with which has sensor on LUN 1, let me know if you'd like for me to attach any logs (tshark, ipmitool -vvv, etc.).

@lukeyeager
Copy link
Contributor Author

@gebn Have you had a chance to take a look at this yet? FWIW, this patch has been working well for me.

Copy link
Owner

@gebn gebn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two minor comments. It's a shame we have to add essentially the same 3 lines to every command, however I can't think of a cleaner way to do this.

pkg/ipmi/command.go Outdated Show resolved Hide resolved
pkg/ipmi/get_sensor_reading.go Outdated Show resolved Hide resolved
@lukeyeager
Copy link
Contributor Author

It's a shame we have to add essentially the same 3 lines to every command, however I can't think of a cleaner way to do this.

I agree. Golang has its upsides, but it also has downsides.

@gebn gebn merged commit d8c3c69 into gebn:master Jul 6, 2023
1 check passed
@lukeyeager lukeyeager deleted the get-sensor-reading-lun1 branch July 7, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteLUN!=0 is not supported
2 participants