From de27f31b167da9cc63734392d8464d27a341436c Mon Sep 17 00:00:00 2001 From: Dave Geddes Date: Mon, 30 Sep 2013 00:32:24 -0600 Subject: [PATCH] refactor (github release) print success message when using --no-write option --- tasks/grunt-release.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tasks/grunt-release.js b/tasks/grunt-release.js index a9d64b5..1233953 100644 --- a/tasks/grunt-release.js +++ b/tasks/grunt-release.js @@ -116,7 +116,7 @@ module.exports = function(grunt){ if (nowrite){ grunt.verbose.writeln('Not actually creating github release: ' + tagName); - done(); + success(); } request @@ -126,13 +126,17 @@ module.exports = function(grunt){ .send({"tag_name": tagName, "name": tagMessage}) .end(function(res){ if (res.statusCode === 201){ - grunt.log.ok('created ' + tagName + ' release on github.'); - done(); + success(); } else { grunt.fail.warn('Error creating github release. Response: ' + res.text); } }); + + function success(){ + grunt.log.ok('created ' + tagName + ' release on github.'); + done(); + } } });