mctp: Fix check for dev_hard_header() result

mkj · davem330 · commit 60be976ac451 · 2022-04-01T12:04:15.000+01:00
dev_hard_header() returns the length of the header, so we need to test for negative errors rather than non-zero. Fixes: 889b7da ("mctp: Add initial routing framework") Signed-off-by: Matt Johnston <matt@codeconstruct.com.au> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/mctp/route.c b/net/mctp/route.c
@@ -512,7 +512,7 @@ static int mctp_route_output(struct mctp_route *route, struct sk_buff *skb)
 
 	rc = dev_hard_header(skb, skb->dev, ntohs(skb->protocol),
 			     daddr, skb->dev->dev_addr, skb->len);
-	if (rc) {
+	if (rc < 0) {
 		kfree_skb(skb);
 		return -EHOSTUNREACH;
 	}

Original file line number	Diff line number	Diff line change
`@@ -512,7 +512,7 @@ static int mctp_route_output(struct mctp_route route, struct sk_buff skb)`
`512`	`512`
`513`	`513`	`rc = dev_hard_header(skb, skb->dev, ntohs(skb->protocol),`
`514`	`514`	`daddr, skb->dev->dev_addr, skb->len);`
`515`		`- if (rc) {`
	`515`	`+ if (rc < 0) {`
`516`	`516`	`kfree_skb(skb);`
`517`	`517`	`return -EHOSTUNREACH;`
`518`	`518`	`}`