Fix Failed to match errors in cargo-geiger
#263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with `Failed to match` errors, which was caused by cargo-metadata behaviour of not resolving dev-dependencies of crate dependency. Now we check if crate is root and if not, we won't collect dev deps for this package, cause they are anyways not in krates graph, which relies on cargo-metadata `resolve` output field. Also changed argument for `Failed to match` error, cause it mentioned not the real one unmatched package. Relates to geiger-rs#240
|
Thanks for working on this - looks to solve most issues - we need to add support for handling workspaces - Like git2-rs still complains about serde but that's because we don't handle items in workspaces e.g. running geiger on it's root: cargo tree does not show serde in graph but yet it's in Cargo.lock via systest crate via workspace which we don't graph these workspace members causing these adidtional failed to matches perhaps; [[package]]
name = "systest"
dependencies = [
..
"ctest",
]
[[package]]
name = "ctest"
version = "0.2.22"
dependencies = [
..
"syntex_syntax2",
]
[[package]]
name = "syntex_syntax2"
version = "0.0.2"
dependencies = [
..
"serde",
"extprim",
]
[[package]]
name = "extprim"
version = "1.7.1"
dependencies = [
..
"serde",
] |
|
p.s. if you want to hang in discord - please feel free to join: https://discord.gg/5E2gQNaB |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with
Failed to matcherrors, which was caused by cargo-metadata behaviour of not resolving dev-dependencies of crate dependency.Now we check if crate is root and if not, we won't collect dev deps for this package, cause they are anyways not in krates graph, which relies on cargo-metadata
resolveoutput field.Also changed argument for
Failed to matcherror, cause it mentionednot the real one unmatched package.
Relates to #240