Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): remove unreasonable attribute #285

Merged
merged 2 commits into from
Jun 23, 2020
Merged

fix(grid): remove unreasonable attribute #285

merged 2 commits into from
Jun 23, 2020

Conversation

unix
Copy link
Member

@unix unix commented Jun 23, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

fixed #284

@unix unix added the type: bug Something isn't working label Jun 23, 2020
@unix unix self-assigned this Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #285 into rc will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               rc     #285   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         186      186           
  Lines        2366     2366           
  Branches      563      541   -22     
=======================================
  Hits         2365     2365           
  Misses          1        1           
Impacted Files Coverage Δ
components/grid/basic-item.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ccc98...14963fd. Read the comment docs.

@unix unix merged commit 8806b64 into geist-org:rc Jun 23, 2020
@unix unix deleted the grid branch June 24, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant