Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] magento/magento2#15255 unlock customer after password reset #33

Merged
merged 16 commits into from
Jun 20, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15534

Unlock customer after password reset

Fixed Issues (if relevant)

  1. Customer who exceeded max login failures not able to login even after reset password magento/magento2#15255: unlock customer after password reset

Manual testing scenarios

  1. After x customer failed login, customer get locked
  2. From backend, it's sent a reset password main
  3. User changes his password
  4. User is still locked

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

dhaecker and others added 16 commits June 8, 2018 16:38
- Adding/updating action groups and elements to support file cleanup after tests
- Adding test files for upload tests
- Fixing/updating image action groups
…8-tech-debt-cleanup-background-attributes-for-banner
- Update special character image file to be cross compatible with all platforms
- Update image cleanup action group to look for file names in image src attribute
- Loosen selector for Image name in src attribute
- Update missed data entity with old special character file name
- Update expected background-position values
- Use a more targeted selector for image upload preview
- Update background-size tests to use visual select action group
- Update tests to handle cleaning up uploaded images better
- Fix additional usages of background-position to use visual select
…ech-debt-cleanup-background-attributes-for-banner
…ech-debt-cleanup-background-attributes-for-banner
- Fixing flakiness in delete image action group
…8-tech-debt-cleanup-background-attributes-for-banner
…ech-debt-cleanup-background-attributes-for-banner
…8-tech-debt-cleanup-background-attributes-for-banner
…0828-tech-debt-cleanup-background-attributes-for-banner

[obsessive] MAGETWO-90828: [Tech Debt] Cleanup Background Attributes for Banner
@gelanivishal gelanivishal merged commit 78b1f53 into 2.3-develop Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants