Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit fails if commit.gpgsign config key is missing #71

Closed
geluk opened this issue Nov 15, 2020 · 2 comments
Closed

Commit fails if commit.gpgsign config key is missing #71

geluk opened this issue Nov 15, 2020 · 2 comments
Assignees
@geluk
Labels
bug

Comments

@geluk
Copy link
Owner

geluk commented Nov 15, 2020

As reported by @xxxcrow in #68. I'm opening a new issue for this since it's an unrelated problem.
geluk added a commit that referenced this issue Nov 15, 2020
@geluk
Handle missing 'gpgsign' config key correctly (#71)
1426fc2
geluk added a commit that referenced this issue Nov 15, 2020
@geluk
Handle missing 'gpgsign' config key correctly (#71)
9ef381c
@geluk
Copy link
Owner Author

geluk commented Nov 15, 2020

Checking the value of the commit.gpgsign fails with a NullReferenceException if the configuration key is missing from the repository.

For now, the easy way to resolve this is by manually setting commit.gpgsign to false in your password store. (git config commit.gpgsign false)

I'll publish a release soon which will fix this issue.

@geluk geluk mentioned this issue Nov 15, 2020
Closed
@geluk geluk self-assigned this Nov 15, 2020
@geluk geluk added the bug label Nov 15, 2020
@geluk
Copy link
Owner Author

geluk commented Feb 6, 2021 •
edited
Loading

v1.11.1 is out now, which fixes this issue.

@geluk geluk closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geluk geluk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geluk