Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework image generation workflow #235

Merged
merged 95 commits into from
May 16, 2024
Merged

Rework image generation workflow #235

merged 95 commits into from
May 16, 2024

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented May 10, 2024 •
edited
Loading

Things undertaken to speed up the workflow:

  • Avoid usage of drawio-export-action (the Docker image is ~800MB and runs the Electron app once for every input file)
  • Avoid usage of setup-graphviz (it's just a frontend for apt-get executed through a node application)
  • Run plantuml export in recursive mode and with parallelization
  • Run draw.io export in recursive mode
  • Don't embed metadata in plantuml exports (since we already have the source files here anyway)
  • Use rsync for selectively copying files

As a breaking change the draw.io exported files don't have a page name suffix anymore (which is a feature of https://github.com/rlespinasse/drawio-exporter). Consequently, some file name usages will have to be adapted.

TVRiddle and others added 20 commits November 22, 2023 11:21
@TVRiddle
new api endpoint implemented
63d98b0
@TVRiddle
Merge pull request #224 from gematik/HOTFIX_New_Cleanup_Endpoint_Test…
afd54d3 
…driver

Hotfix new optional cleanup endpoint testdriverapi
@Beff42
Adds room version to test api
3ead26b
@Beff42
Adds room version to releaseNotes
e4aef75
@Beff42
Bumps version number
7143484
@TVRiddle
Merge pull request #225 from gematik/gematik/HOTFIX_Add_room_version
a4961d1 
Adds room version to test api
@marcusfey @ichderjens
fix links from idp.adoc to internal requirements documents
e7a05b7
@Beff42 @TVRiddle
Adds better documentation of where the mxid is required in its url fo… (
6f7d025 
#228)

* Adds better documentation of where the mxid is required in its url format



---------

Co-authored-by: TVRiddle <44850999+TVRiddle@users.noreply.github.com>
@Beff42
Fixes issue with code generation
2e999ca
@Beff42
Merge pull request #229 from gematik/gematik/HOTFIX_Fixes_formatting
4879286 
Fixes issue with code generation
@gem-aw
new tags in TiMessengerTestTreiber.yaml
bdc43ca
@Beff42
Merge remote-tracking branch 'origin/gematik/HOTFIX_Restructures_endp…
cf5fd17 
…oint_sorting' into gematik/HOTFIX_Restructures_endpoint_sorting
@Beff42
Merge pull request #232 from gematik/gematik/HOTFIX_Restructures_endp…
2f777f3 
…oint_sorting

new tags in TiMessengerTestTreiber.yaml
@marlenebuelt
TIM-TS 446: allow FHIR enum state "off"
74e72df
@marlenebuelt
TIM-TS 446: added correct versions
9ded2b4
@Beff42
Updates release version
d921668
@Beff42
Merge pull request #234 from gematik/HOTFIX_changes_endpoint_enum_to_…
dbe5750 
…fhir_compliant_off

TIM-TS 446: allow FHIR enum state "off"
@Beff42
Marks required properties as required (#233)
c15b9c8 
* Marks required properties as required

* Bumps api version

* Merges incoming changes
@Johennes @ichderjens
Fix typo
52065fc
@Johennes
Speed up image generation workflow
0464a2d
@Johennes Johennes force-pushed the johannes/generate-images branch from 07d1f2e to 0464a2d Compare May 10, 2024 14:22
@Johennes Johennes requested a review from ichderjens May 10, 2024 14:26
Johennes and others added 27 commits May 16, 2024 10:10
@Johennes
Move file
c016c75
@Johennes
Move file back
88c3e42
@Johennes
Commit from GitHub Actions (draw.io images)
09c54fe
@Johennes
Fix case
37eedee
@Johennes
Try using image macro
cce77c8
@Johennes
Use block image
9ead429
@Johennes
Try using align attribute
a1cecf9
@Johennes
Revert to original version
58efe9b
@Johennes
Use image block
20531a1
@Johennes
Use image block
5b1a520
@Johennes
Use inline image
0a9ffa7
@Johennes
Insert back block delimiters
11c7a97
@Johennes
Replace remaining imgs
49fb8ab
@Johennes
Nuke puml exports
fd3bf8c
@Johennes
Commit from GitHub Actions (PlantUML images)
4a5995f
@Johennes
Remove and assert absence of puml output file names
0ada0b4
@Johennes
Commit from GitHub Actions (PlantUML images)
a17ed66
@Johennes
empty
b548e49
@Johennes
Ensure absence of img tags
3ad1d70
@Johennes
Run lint as part of export
e2253fc
@Johennes
Merge workflows and add linting
d602b6e
@Johennes
Add shell
669081b
@Johennes
Remove empty line
1e1a772
@Johennes
Fix file names
1e875e7
@Johennes
Fix name
944da5c
@Johennes
Nuke images
5683214
@Johennes
Commit from GitHub Actions (Generate images)
d6f3d3c
@Johennes Johennes merged commit 1b95b05 into tim-epa-fdv May 16, 2024
@Johennes Johennes deleted the johannes/generate-images branch May 16, 2024 14:05
@Johennes Johennes changed the title Speed up image generation workflow Rework image generation workflow May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichderjens ichderjens Awaiting requested review from ichderjens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Johennes @TVRiddle @Beff42 @marcusfey @gem-aw @marlenebuelt