Skip to content

Commit

Permalink
Merge pull request #25 from genai-musings/eoinhalpin99-patch-1
Browse files Browse the repository at this point in the history
Ensure docker image pushed to Docker Hub before README.md
  • Loading branch information
tom-halpin authored Oct 15, 2023
2 parents 8dd41ae + 9744fad commit 8e943dd
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Codeowners file
# syntax: https://help.github.com/en/articles/about-code-owners
* @tom-halpin
* @tom-halpin @eoinhalpin99
12 changes: 8 additions & 4 deletions .github/workflows/docker-push-readme.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
name: Push README to Docker Hub

on:
push:
branches:
- main
workflow_run:
workflows: "Build and Push Docker Image"
types:
- completed
push:
branches:
- main

jobs:
PushContainerReadme:
Expand All @@ -21,4 +25,4 @@ jobs:
destination_container_repo: ${{ secrets.DOCKERHUB_USERNAME }}/template-repo-template
provider: dockerhub
short_description: 'Hello world sample application for Python template GitHub repository.'
readme_file: 'README.md'
readme_file: 'README.md'
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.6.1] - 2023-10-15

- [ADDED] Ensured docker image pushed to Docker Hub before README.md
- [CHANGED] Codeowners and Dockerfile maintainers

## [1.6.0] - 2023-09-13

- [ADDED] GitHub Action Linting to Super-Linter workflow
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Use a base Python image
FROM python:3.11

LABEL maintainer=“tom_halpin@hotmail.com”
LABEL maintainer=“tom_halpin@hotmail.com,eoinhalpin99@gmail.com
LABEL description="Hello world sample application for Python template GitHub repository."

# Set the working directory inside the container
Expand Down

0 comments on commit 8e943dd

Please sign in to comment.