Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure docker image pushed to Docker Hub before README.md #25

Merged
merged 7 commits into from
Oct 15, 2023

Conversation

eoinhalpin99
Copy link
Collaborator

Proposed changes

Describe the proposed changes. This is your opportunity to communicate to the maintainers of this repository as to why we should accept your PR. If your PR fixes a bug or resolves a feature request please include a link to the associated issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue)
  • Code style update (formatting, renaming)
  • Documentation update (if none of the other choices apply)
  • New feature (non-breaking change which adds functionality)

Checklist

Put an x in the boxes that apply you can view the checklist as a heads up as to what we are going to look for before merging your code.

  • I have added a description of the changes made in this PR to CHANGELOG.md.
  • I have read the CONTRIBUTING.md guidelines for this repository.
  • I have included any and all necessary documentation where appropriate.
  • I will fix any problems reported with this PR by the GitHub Actions on this repository.

Further comments

Feel free to to explain in more detail why you chose the solution you did including what if any alternatives you considered where applicable.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first Pull Request to this repository. We will review it and get back to you shortly. name: Greetings

@eoinhalpin99 eoinhalpin99 marked this pull request as ready for review October 15, 2023 10:47
Copy link
Collaborator

@tom-halpin tom-halpin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty

@tom-halpin tom-halpin merged commit 8e943dd into main Oct 15, 2023
8 checks passed
@eoinhalpin99 eoinhalpin99 deleted the eoinhalpin99-patch-1 branch October 19, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants