http and ftp proxy variables should be lowercase #123
Conversation
As per make.conf documentation, the only two variables that are actually not uppercase, are "http_proxy" and "ftp_proxy.
| @@ -1,5 +1,7 @@ | |||
| <% if @content == '' -%> | |||
| <%= @name %> | |||
| <% elsif @name == 'http_proxy' or @name == 'ftp_proxy' -%> | |||
There was a problem hiding this comment.
Is it possible to move this input munging to the definition instead of doing it in the template?
There was a problem hiding this comment.
I'm not 100% sure if I understand correctly, by "moving it to the definition", you mean moving all of it into makeconf.pp where makeconf is defined? If so, without making this module dependent on stdlib or duplicating code from it, the only way to achieve filtering and changing case is by using inline ruby if I'm not mistaken?
I'm not exactly sure if this results in better readable code. I agree it might not be the best position to do this at template level, but one could argue it's merely ensuring the proper make.conf syntax is generated. Why not do so at the lowest possible level, the template.
There was a problem hiding this comment.
Could inline_template be another way to do it? Anyway, we planned to
convert portage::makeconf into a native provider for more flexibility,
see #56.
As per make.conf documentation, the only two variables that are
actually not uppercase, are "http_proxy" and "ftp_proxy.