delete_subkey_all() does not delete itself when subkey's path is empty. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo90
reviewed
Oct 5, 2017
| let c_path; | ||
| let path_ptr; | ||
| if path.as_ref().is_empty(){ | ||
| path_ptr = ptr::null(); |
There was a problem hiding this comment.
Is this necessary? I've just checked and it looks like RegDeleteTreeW behaves the same way with NULL pointer and pointer to an empty string in second argument. It deletes all subkeys and values in both cases.
There was a problem hiding this comment.
"NULL pointer " and empty sting get the same result. The reason I add these codes is MSDN told me to to do that. BTY this avoid mem alloc in to_utf16().
gentoo90
added a commit
that referenced
this pull request
Nov 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.