SHOW CONFIGS now gets all configs
#1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: evadb/catalog/catalog_manager.py Added case to get all configs modified: evadb/executor/show_info_executor.py Test for get all configs modified: test/integration_tests/short/test_show_info_executor.py
|
@gaurav274 and @xzdandy what should I compare it against in the all configs test? A little confused about that |
|
Solves #1286 |
2 tasks
modified: evadb/catalog/catalog_manager.py modified: test/integration_tests/short/test_show_info_executor.py
xzdandy
reviewed
Nov 10, 2023
xzdandy
reviewed
Nov 10, 2023
xzdandy
reviewed
Nov 10, 2023
modified: .gitignore Changed keyword to CONFIGS in place of CONFIG modified: docs/source/reference/evaql/set_config.rst modified: docs/source/reference/evaql/show_config.rst modified: evadb/evadb_config.py modified: evadb/executor/set_executor.py modified: evadb/executor/show_info_executor.py modified: evadb/parser/lark_visitor/_show_statements.py modified: evadb/parser/show_statement.py modified: evadb/parser/types.py modified: evadb/plan_nodes/show_info_plan.py Updated tests for CONFIGS modified: test/integration_tests/short/test_show_info_executor.py modified: test/unit_tests/parser/test_parser.py
hershd23
changed the title
SHOW CONFIG now gets all configsSHOW CONFIGS now gets all configs
xzdandy
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method to get all configs
modified: evadb/catalog/catalog_manager.py
Added case to get all configs
modified: evadb/executor/show_info_executor.py
Test for get all configs
modified: test/integration_tests/short/test_show_info_executor.py