Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ci test for third party integration #940

Merged
merged 9 commits into from
Aug 22, 2023
Merged

feat: update ci test for third party integration #940

merged 9 commits into from
Aug 22, 2023

Conversation

jiashenC
Copy link
Member

No description provided.

@jiashenC jiashenC requested review from gaurav274 and xzdandy August 20, 2023 15:06
@xzdandy
Copy link
Collaborator

xzdandy commented Aug 21, 2023

The test/third_party_tests/test_native_executor.py is failing:

FAILED test/third_party_tests/test_native_executor.py::NativeExecutorTest::test_should_run_simple_query_in_postgres - evadb.executor.executor_utils.ExecutorError: 'PostgresHandler' object has no attribute 'connection'

@jiashenC
Copy link
Member Author

The test/third_party_tests/test_native_executor.py is failing:

FAILED test/third_party_tests/test_native_executor.py::NativeExecutorTest::test_should_run_simple_query_in_postgres - evadb.executor.executor_utils.ExecutorError: 'PostgresHandler' object has no attribute 'connection'

Addressed this by skipping third-party integration tests in normal tests.

@xzdandy xzdandy merged commit 75073c7 into master Aug 22, 2023
@xzdandy xzdandy deleted the ci-for-integration branch August 22, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiashenC @xzdandy