feat: select from native database #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiashenC
force-pushed
the
select-from-native-database
branch
from
174b306 to
f421ea1
Compare
|
@xzdandy @gaurav274 Can you give a review of the design here? I will add more tests later. |
|
The design looks good to me. |
xzdandy
approved these changes
Aug 23, 2023
|
Could we add documentation on how to connect to existing databases and run native queries? |
I can add later once the mintify docs is merged? If I add to readdocs now. It anyway needs to be ported over again. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.